Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base AMI to Debian Bookworm #242

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Update base AMI to Debian Bookworm #242

merged 6 commits into from
Mar 7, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 14, 2023 •
edited by mcdonnnj
Loading

🗣 Description

This pull request updates the base AMI from Debian Bullseye to Debian Bookworm.

💭 Motivation and context

Debian Bookworm was officially released on June 10, 2023.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates labels Jun 14, 2023
@jsf9k jsf9k marked this pull request as ready for review June 14, 2023 13:36
@jsf9k jsf9k requested review from felddy, jasonodoom, dav3r, mcdonnnj and a team June 14, 2023 13:36
mcdonnnj
mcdonnnj approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mcdonnnj
Copy link
Member

@jsf9k Until we come to a final determination on handling the change in Bookworm from using resolvconf to systemd-resolved for DNS resolution would it be fair to mark this as blocked?

@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 23, 2023
@jsf9k jsf9k mentioned this pull request Jan 10, 2024
Closed
@jsf9k jsf9k force-pushed the improvement/upgrade-to-debian-bookworm branch from a754554 to e315ebe Compare January 12, 2024 20:10
@jsf9k jsf9k linked an issue Jan 12, 2024 that may be closed by this pull request
DNS woes with Debian Bookworm #300
Closed
@jsf9k
Copy link
Member Author

jsf9k commented Jan 12, 2024

Please note that the linter failures are because this PR is lacking the changes from PR #295. Once that PR is merged then this one should also pass its checks.

dav3r
dav3r approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k
Copy link
Member Author

jsf9k commented Jan 12, 2024

@mcdonnnj - Can you post something here and/or in #300 when your CyHy testing is complete?

@jsf9k
Copy link
Member Author

jsf9k commented Feb 15, 2024

@mcdonnnj - Can you post something here and/or in #300 when your CyHy testing is complete?

@mcdonnnj - Does cisagov/cyhy_amis#746 mean that your testing is complete and successful?

@jsf9k jsf9k removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 15, 2024
@mcdonnnj mcdonnnj mentioned this pull request Feb 16, 2024
Merged
7 tasks
@mcdonnnj
Copy link
Member

@mcdonnnj - Can you post something here and/or in #300 when your CyHy testing is complete?

@mcdonnnj - Does cisagov/cyhy_amis#746 mean that your testing is complete and successful?

It does now. I meant to create that as a draft PR while I did some last verification. I have finished that verification and added a small update to #300 confirming success.

This was referenced Feb 16, 2024
Merged
Merged
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Mar 4, 2024
@jsf9k jsf9k assigned jsf9k and unassigned jmorrowomni Mar 6, 2024
@mcdonnnj mcdonnnj force-pushed the improvement/upgrade-to-debian-bookworm branch from b320607 to cc0ab41 Compare March 7, 2024 13:58
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2024
jsf9k and others added 6 commits March 7, 2024 16:12
@jsf9k @mcdonnnj
Update base AMI to Debian Bookworm
907f68a 
Debian Bookworm was officially released on June 10,2023.
@jsf9k @mcdonnnj
Add a playbook to install prerequisites for fixing a broken Netplan c…
39e3d31 
…onfiguration

See these issues for more information:
- #300
- canonical/cloud-init#4764
@jsf9k @mcdonnnj @dav3r
Rename playbook to better describe what it does
90277d7 
Co-authored-by: Nick <[email protected]>
Co-authored-by: dav3r <[email protected]>
@jsf9k @mcdonnnj
Add comments mentioning #301
cf34d76 
These comments remind us to remove the code to fix up the Netplan
configuration generated by cloud-init when and if that becomes
possible.
@mcdonnnj
Finalize version from 1.0.0-rc.2 to 1.0.0
341e7af
@mcdonnnj
Reorder YAML keys to placate ansible-lint
41cc1f9
@mcdonnnj mcdonnnj force-pushed the improvement/upgrade-to-debian-bookworm branch from 6c1a92b to 41cc1f9 Compare March 7, 2024 21:18
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 7, 2024
Merged via the queue into develop with commit c7b9ec8 Mar 7, 2024
11 checks passed
@mcdonnnj mcdonnnj deleted the improvement/upgrade-to-debian-bookworm branch March 7, 2024 21:41
@jsf9k jsf9k mentioned this pull request Mar 15, 2024
Merged
11 tasks
jsf9k added a commit to cisagov/freeipa-server-packer that referenced this pull request Mar 22, 2024
@jsf9k
Remove Netplan code from cisagov/skeleton-packer#242
f114ab8 
Fedora does not use Netplan, so this code is not necessary for this
AMI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jasonodoom jasonodoom jasonodoom approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release upstream update This issue or pull request pulls in upstream updates
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS woes with Debian Bookworm
6 participants
@jsf9k @mcdonnnj @jasonodoom @dav3r @dv4harr10 @jmorrowomni