Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ansible-core pin when that becomes possible #312

Closed
jsf9k opened this issue Mar 8, 2024 · 0 comments · Fixed by #338
Closed

Revert ansible-core pin when that becomes possible #312

jsf9k opened this issue Mar 8, 2024 · 0 comments · Fixed by #338
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Mar 8, 2024 •
edited
Loading

💡 Summary

The ansible-core pin in requirements.txt should be removed when and if that becomes possible.

See also:

Motivation and context

ansible-core 2.16.3 and later currently suffer from the bug discussed in ansible/ansible#82702, which breaks any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. Once this issue is addressed the pin can be removed.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 8, 2024
jsf9k added a commit that referenced this issue Mar 8, 2024
@jsf9k
Include a reference to #312
611a82b 
This issue reminds us to remove the pin against ansible-core when that
becomes possible.
jsf9k added a commit that referenced this issue Mar 10, 2024
@jsf9k
Include a reference to #312
68b5c50 
This issue reminds us to remove the pin against ansible-core when that
becomes possible.
@jsf9k jsf9k changed the title Revert ansible-core pin when that becomes possible. Revert ansible-core pin when that becomes possible Mar 10, 2024
jsf9k added a commit that referenced this issue Mar 10, 2024
@jsf9k
Include a reference to #312
900bf49 
This issue reminds us to remove the pin against ansible-core when that
becomes possible.
jsf9k added a commit that referenced this issue Mar 10, 2024
@jsf9k
Include a reference to #312
21c2ca4 
This issue reminds us to remove the pin against ansible-core when that
becomes possible.
jsf9k added a commit to cisagov/openvpn-packer that referenced this issue Mar 13, 2024
@jsf9k
Include a reference to cisagov/skeleton-packer#312
b310cba 
This issue reminds us to remove the pin against ansible-core when that
becomes possible.
This was referenced May 6, 2024
Closed
Closed
@jsf9k jsf9k mentioned this issue May 21, 2024
Merged
6 tasks
@desebjohnston desebjohnston mentioned this issue Jun 17, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update version pin on ansible-core Python package cisagov/skeleton-packer
1 participant
@jsf9k