Add 117 Non-.Gov Base Domains for HHS #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHS sent us a long list of domains to add to their BOD 18-01 reports. We reviewed all the base domains for association that it was either managed by or specifically on HHS' behalf, resulting in the smaller number of adds you see here.
climber-girl
added a commit
to climber-girl/data
that referenced
this pull request
May 14, 2021
HHS sent us a long list of domains to add to their BOD 18-01 reports. We reviewed all the non-.gov base domains for association that it was either managed by or specifically on HHS' behalf, resulting in the smaller number of adds you see at cisagov/scan-target-data#48. These are the subdomains for those that were included in the list.
jsf9k
approved these changes
May 17, 2021
jsf9k
added a commit
to cisagov/gatherer
that referenced
this pull request
May 17, 2021
Several non-.gov top-level domains have been added recently via cisagov/scan-target-data#45 and cisagov/scan-target-data#48. Automatically extracting the list of domains is a much more maintainable and much less error-prine solution than continuing to add manually them.
6 tasks
climber-girl
added a commit
to climber-girl/dotgov-data
that referenced
this pull request
May 18, 2021
This pull request aligns with the pull request of the equivalent GSA/Data/other-websites file, which I do not believe GSA is watching or maintaining. We should probably start managing our own list as started here and point the gatherer at this list instead of https://github.com/GSA/data/blob/master/dotgov-websites/other-websites.csv. This would be in alignment with what we did in cisagov/gatherer#51 (the line in https://github.com/cisagov/gatherer/blob/develop/gather-domains.sh in this case which would need to be modified would be line 99, I think). ---- HHS requested we add a large handful of subdomains not showing up in their HTTPS/Trustymail reports. The original list has been compared to the list we are currently scanning, and those that weren't already being scanned have been added here. HHS sent us a long list of domains to add to their BOD 18-01 reports. We reviewed all the non-.gov base domains for association that it was either managed by or specifically on HHS' behalf, resulting in the smaller number of adds you see at cisagov/scan-target-data#48. These are the subdomains for those that were included in the list. SBA has requested that we add disasterloanassistance.sba.gov so that it shows up in their Trustymail and HTTPS reports. I verified it is not currently being picked up in the sources gathered by double checking for its presence in their report.
jsf9k
added a commit
to cisagov/gatherer
that referenced
this pull request
May 20, 2021
Several non-.gov top-level domains have been added recently via cisagov/scan-target-data#45 and cisagov/scan-target-data#48. Automatically extracting the list of domains is a much more maintainable and much less error-prine solution than continuing to add manually them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHS sent us a long list of domains to add to their BOD 18-01 reports. We reviewed all the base domains for association that it was either managed by or specifically on HHS' behalf, resulting in the smaller number of adds you see here.