Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HSTS check #203

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Update HSTS check #203

wants to merge 9 commits into from

Commits on Aug 13, 2019

  1. Changes HSTS header processing to more closely follow RFC specificati… 

    …ons. Removed regex based string manipulation in favor of simple split calls.
    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    8ad8512 View commit details
    Browse the repository at this point in the history

  2. Add logic to reflect that the max-age directive is required for HSTS … 

    …headers.
    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    888da78 View commit details
    Browse the repository at this point in the history

  3. Clarify wording in the warning message about multiple HSTS headers.

    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    2b15f92 View commit details
    Browse the repository at this point in the history

  4. Bump version from 0.6.6 to 0.6.7

    @jsf9k
    jsf9k committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    262e991 View commit details
    Browse the repository at this point in the history

  5. Change the directive splitting to be clearer to what's going on. Add … 

    …a comment to explain the hsts_max_age check rationale.
    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    482d025 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'update_hsts_logic' of github.com:cisagov/pshtt into upd… 

    …ate_hsts_logic
    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    3517b0b View commit details
    Browse the repository at this point in the history

  7. Improve comment for HSTS max-age value check

    @jsf9k
    jsf9k committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    cb7399f View commit details
    Browse the repository at this point in the history

  8. Change a check to only fail hsts on negative and non instead of zero … 

    …or negative and none. Added links to relevant sections explaining multiple HSTS headers.
    @mcdonnnj
    mcdonnnj committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    365b9d3 View commit details
    Browse the repository at this point in the history

  9. Rework max-age comment a little 

    Now that we're only checking strictly for compliance to the RFC, the
wording needs to be reworked a little.
    @jsf9k
    jsf9k committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    0f4bb9c View commit details
    Browse the repository at this point in the history