-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Pinning for "Operational" *master* Branch #145
Conversation
Given the recent trouble with our dependencies drifting in and out of compatability, I'm proposing we version pin *master* to a conservative, known-to-be-working set. I took a naive approach here and just `==` the latest versions of various components that I knew worked for my personal usage. There may be a more pythonic way of doing this, but I'm not super familiar with the idioms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I think this is the other good reason to have requirements.txt
vs defining dependencies in your setup.py
file that I wasn't thinking about on #139
Might this complicate installation alongside other
I'm afraid that nailing down the versions will require us to continually tweak the versions to allow |
That's a super fair point that I hadn't considered. I'm very Docker-centric, and I wasn't thinking of potential package management issues outside of containers. Does Python have anything akin to Ruby's Bundler? I'm so used to having tight, project-level control over these types of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm of the opinion that we should not merge this. Instead we should just let #146 get merged into master
the next time we do a PyPI release. I think this may break a lot of interoperability with other packages and it be a headache to maintain.
I could be convinced otherwise, though.
I've definitely experienced more issues with pshtt's requirements being too locked-down (where the point versions fall out of date from upstream dependencies), than I have issues with it being too flexible. But in general, I am not using a Docker-based workflow, and am generally just relying on #146 also looks more promising, but I do think that for this project to hit its greatest potential, it should have solid Docker and non-Docker stories. I wonder if this actually points to a synchronous video meeting or something to work out a reasonable path. |
Closing in favor of resolving #146 one way or the other. |
…s/checkout-4 Bump actions/checkout from 3 to 4
Given the recent trouble with our dependencies drifting in and out of compatability, I'm proposing we version pin master to a conservative, known-to-be-working set. I took a naive approach here and just
==
the latest versions of various components that I knew worked for my personal usage. There may be a more pythonic way of doing this, but I'm not super familiar with the idioms.