Dockerfile Tweaks and Cleanup #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing issue #: - I corrected the variable expansion issue with `WORKDIR` in the `Dockerfile`. - Did some light "copy editing". - Deleted the `entrypoint.sh` script. - Corrected some of the flags in `run`.
Closed
|
I love deleting code! And it looks good to me, but deferring to @jsf9k as a better Docker reviewer. |
|
@egyptiankarim, thanks for catching the error and thanks for getting rid of |
jsf9k
requested changes
Nov 30, 2017
Dockerfile
Outdated
| RUN mkdir ${PSHTT_HOME} | ||
|
|
||
| # Create an unprivileged user | ||
| RUN groupadd --system pshtt |
There was a problem hiding this comment.
@egyptiankarim, do you mind combining these two RUN statements like they were originally? I'm kind of insane about combining related statements where possible to reduce the number of layers in the Docker image.
|
|
||
| # Install pshtt | ||
| COPY . ${PSHTT_HOME} | ||
| RUN chown -R pshtt:pshtt ${PSHTT_HOME} | ||
| RUN pip install --no-cache ${PSHTT_HOME} | ||
|
|
||
| # Prepare to run | ||
| WORKDIR PSHTT_HOME | ||
| WORKDIR ${PSHTT_HOME} |
| `# Change the ownership of the files (**e.g** results) to the user with id 1042 and to the group with id 1042` \ | ||
| -e USER_ID=1042 \ | ||
| -e GROUP_ID=1042 \ | ||
| -v $(pwd):/home/pshtt \ |
There was a problem hiding this comment.
Getting rid of some magic numbers! 👍
|
@egyptiankarim You should be able to check a box somewhere that lets @jsf9k make changes on the PR directly. I know it lets you do at post-time, not as certain about after posting. |
cisagovbot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Add nixfmt pre-commit hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #144:
WORKDIRin theDockerfile.entrypoint.shscript.run.