Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag released versions #111

Closed
IanLee1521 opened this issue Sep 18, 2017 · 4 comments
Closed

Tag released versions #111

IanLee1521 opened this issue Sep 18, 2017 · 4 comments

Comments

@IanLee1521
Copy link
Collaborator

We should make sure to tag the released versions in the git repo to ensure we know what has gotten released.

For instance, do we know for sure what commit s responsible for: https://pypi.python.org/pypi/pshtt/0.2.3 ?

@jsf9k
Copy link
Member

jsf9k commented Apr 6, 2018

TravisCI is now automatically deploying to PyPI and Docker Hub when the repo is tagged. (The version information comes from the file pshtt/__init__.py.) This resolves this issue.

I've also added some helper scripts in the root directory of the project for bumping versions and tagging. These are bump_version.sh and tag.sh, respectively.

@jsf9k jsf9k closed this as completed Apr 6, 2018
@IanLee1521
Copy link
Collaborator Author

That is so cool! I didn't realize there was a semver package.

One... Question...? With a lot of these things, I like to make the git push a separate (manual) action, e.g. https://github.com/dhs-ncats/pshtt/blob/c3a0d360660c7d6a4ecab8ecf54e5a69acb44d0b/bump_version.sh#L22

-- Thoughts?

That way I can go back and fix it up if I did something accidentally.

@jsf9k
Copy link
Member

jsf9k commented Apr 6, 2018

I only thought to look for such a package because I've used this semver package in the past when working with npm.

I first had bump_version.sh without the git push, for the very reason you mention, but I quickly got tired of having to do the separate manual push step. I think there's an argument for doing it either way.

Since I intend to make similar changes to trustymail, do you mind giving the pshtt setup.py and setup.cfg files a look and making sure there is nothing we want to add or tidy up there? (You're more experienced in Python packaging than I am.)

Incidentally, it's pretty cool that the new PyPI website supports markdown syntax. I was able to just read in our README.md and use it as the long_description.

@IanLee1521
Copy link
Collaborator Author

Sure thing! I'll take a look today or over the weekend.

And yes, that Markdown support is awesome. I'd been following that conversation / ticket / feature request for a long time. This will be the first time I've seen it used. :)

cisagovbot pushed a commit that referenced this issue Jan 7, 2023
…orp/setup-terraform-2

Bump hashicorp/setup-terraform from 1 to 2
cisagovbot pushed a commit that referenced this issue Jan 7, 2023
…configuration

Update the version of the second `bandit` hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants