Add the ability to configure the cyhy-commander's jobs-per-*-host values
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Aug 24, 2023
Add the ability to configure the `jobs-per-nessus-host` and `jobs-per-nmap-host` values for the `production` section in the `commander.conf` file through the Terraform configuration.
Sorting these alphabetically aligns with our general practice of sorting such arguments as long as order is not important.
mcdonnnj
force-pushed
the
improvement/configure_commander_jobs-per-host
branch
from
15172c9
to
01f352b
Compare
dav3r
approved these changes
Aug 25, 2023
Make sure to mention that all three variables are only used in the "production" section of the generated configuration file. Co-authored-by: dav3r <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds the ability to configure the
jobs-per-nessus-hostandjobs-per-nmap-hostvalues in the cyhy-commander configuration file.💭 Motivation and context
We want to update the value being deployed in production but rather than continuously modifying a hard-coded value it made sense to integrate this as a configurable value between the Ansible role and the Terraform configuration.
🧪 Testing
Automated tests pass. I deployed this in my development environment with a non-default value and confirmed it deployed successfully.
✅ Pre-approval checklist
to reflect the changes in this PR.