Bump production portscan instances from t3.small to t3.medium
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are moving to a larger instance type for the portscan instances in production environments.
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Aug 24, 2023
mcdonnnj
deleted the
improvement/change_portscanner_instance_type_in_production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This changes the AWS EC2 instance type used for
portscaninstances in production workspaces to uset3.mediuminstead oft3.small.💭 Motivation and context
We are moving these instances to a larger instance type to support putting more jobs on a given instance. Since we have a limited number of
portscaninstances we can spin up (due to networking configurations and IP address availability) we need the ability to put more work on each instance.This aligns the Terraform configuration in this repository with what is currently deployed to production for these instances.
🧪 Testing
✅ Pre-approval checklist