Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full backtrace #14

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Enable full backtrace #14

merged 1 commit into from
Dec 14, 2022

Conversation

fkorotkov
Copy link
Contributor

To include line numbers. Right now errors doesn't contain them:

Connection reset by peer (os error 54)

Thread 0
0   softnet                         0x100633cb0         softnet::proxy::Proxy::run
1   softnet                         0x1003f0d0c         softnet::main
2   std                             0x1003f13f4         std::sys_common::backtrace::__rust_begin_short_backtrace
3   std                             0x1003f140c         std::rt::lang_start::{{closure}}
4   std                             0x1006c2fc4         std::rt::lang_start_internal
5   <unknown>                       0x1003f13b8         _main

To include line numbers
@edigaryev
Copy link
Collaborator

I think there's no difference between 1 and full both internally and in the docs.

The symbolication worked fine on local machine because the symbols were present in the build directory, and sofnet binary was referring to them.

To make this work on any machine, it seems that we have to upload the symbols (and additionally sources, to enrich the issue view even more in the Sentry UI), I've created #15 to address this.

@fkorotkov
Copy link
Contributor Author

There is a mention of the full here. And even there is such BacktraceStyle. 🤔

@edigaryev
Copy link
Collaborator

There is a mention of the full here. And even there is such BacktraceStyle. 🤔

Indeed, but this feature doesn't seem to be stabilized yet (rust-lang/rust#93346) nor does it seem to influence anything in our case (we're only interested in Backtrace::enabled(), otherwise Backtrace::capture() wouldn't work).

Still, I think we can merge it anyway to be future-proof.

@fkorotkov fkorotkov merged commit a1108b1 into main Dec 14, 2022
@fkorotkov fkorotkov deleted the full-backtrace branch December 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants