-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selectable number of CPUs for docker_builder #741
Labels
Comments
Good idea! Can't hurt to have faster build times 😄 |
fkorotkov
added a commit
that referenced
this issue
Feb 22, 2021
asomers
added a commit
to asomers/nix
that referenced
this issue
Feb 23, 2021
asomers
added a commit
to asomers/nix
that referenced
this issue
Feb 23, 2021
asomers
added a commit
to asomers/nix
that referenced
this issue
Feb 23, 2021
asomers
added a commit
to asomers/nix
that referenced
this issue
Feb 23, 2021
I tried following the instructions in 25346a5 , but they don't work. My builds failed with a task:
env:
...
matrix:
...
compute_engine_instance:
image_project: cirrus-images
image: family/docker_builder
platform: linux
cpu: 1 # Since QEMU will only use 1 thread
memory: 4G
setup_script:
... |
@asomers should be |
asomers
added a commit
to asomers/nix
that referenced
this issue
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
docker_builder
task should support a selectable number of CPUs. Right now it's hard-coded to 4.Context
The Nix project has some tasks that must use
docker_builder
, even though they can only take advantage of a single CPU. So we're wasting resources. Our builds would schedule sooner, and your bills would be lower, if we could reduce the CPU count.Anything Else
The task in question:
https://github.com/nix-rust/nix/blob/5729d0f391775c98699f0f92f8df6b7f5f49fc7d/.cirrus.yml#L53
The text was updated successfully, but these errors were encountered: