Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare m1 build pipeline #669

Merged
merged 22 commits into from
Jan 31, 2024
Merged

prepare m1 build pipeline #669

merged 22 commits into from
Jan 31, 2024

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Jan 15, 2024

https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Made windows versions capitalized so they appear first in file list.

https://github.com/axu2/kcc/releases/tag/v5.7.0

image

image

% arch -x86_64 python3
Python 3.11.4 (v3.11.4:d2340ef257, Jun  6 2023, 19:15:51) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
>>> platform.machine()
'x86_64'
>>> platform.processor()
'i386'

% python3
Python 3.11.4 (v3.11.4:d2340ef257, Jun  6 2023, 19:15:51) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
>>> platform.machine()
'arm64'
>>> platform.processor()
'arm'

I don't think a universal2 build is possible, it requires all of our dependencies to also be universal2.

The reason for that is that even with a universal2 python environment, some packages may end up providing only single-arch binaries, making it impossible to create a functional universal2 frozen application.

In such cases, creating frozen application for the selected target architecture will not be possible unless the problem of missing arch slices is manually addressed (for example, by downloading the wheel corresponding to the missing architecture, and stiching the offending binary files together using the lipo utility).

https://pyinstaller.org/en/stable/feature-notes.html#macos-multi-arch-support

@axu2 axu2 changed the title add m1 build pipeline prepare m1 build pipeline Jan 19, 2024
@axu2 axu2 marked this pull request as ready for review January 30, 2024 18:12
@axu2
Copy link
Collaborator Author

axu2 commented Jan 30, 2024

@darodi GitHub has released free M1 runners! I confirm it works great 2x faster than Rosetta. @AcidWeb in case you are interested too.

@axu2 axu2 requested a review from darodi January 30, 2024 18:16
@darodi
Copy link
Collaborator

darodi commented Jan 31, 2024

see also

FlyCI has M1 and M2 runners with a free tier for M1s. Our runners are on average 2x faster and 2x cheaper than GitHub's.
Originally posted by @kgantchev in #523 (comment)

@axu2 axu2 merged commit 33cc324 into ciromattia:master Jan 31, 2024
@axu2 axu2 deleted the m1 branch January 31, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants