Fix issue #686 for circusctl as well (refactored) #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the name of the corresponding attribute on real Watcher instances. This will be important when adding tests for code that accesses this attribute (e.g. any test that covers commands/incrproc.py line 64).
Note that the decr command fails this test while incr passes the analogous test already.
The decr command now passes test added in 0e8982f.
|
Sorry for the very long delay. This PR looks fine for me, let's merge it (I'll add a small patch to please flake8 as well). |
douardda
pushed a commit
that referenced
this pull request
Jan 12, 2016
…tored Fix issue #686 for circusctl as well (refactored)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #686 was partially fixed by disabling the decr link in circus-web but the problematic behaviour is still accessible through
circusctl decrand presumably raw ZMQ.This replaces PR #931.
Just like 931 it:
DecrProcesstoDecrProcfor consistency withIncrProcIncrProcinDecrProcContrary to 931, to address @douardda's comment on 931, it:
FakeArbiterto support singletonFakeWatchers, instead of refactoringFakeArbiterto support dependency injection of the watcher class. This is similar to howtest_command_set.pysubclassesFakeArbiterand does not affect any of the other test files that importFakeArbiterfromtest_command_incr.py.