Support tests for up to py3.13 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required for the `test_venv_site_packages` in `tests/test_watcher.py`
scottkmaxwell
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to just update the tests, a class from unittest that was removed in py3.13 but was nowhere used in the code. There was nothing I had to change in the source code to let the test pass for py3.12 and py3.12.
Also I ran aiida-core test suite with the almost latest version on master (I branched of PR #1218 a month ago or so) and almost all tests pass (see test suite run). Only 2 tests fail but I dont think they are related to circus.
This PR is related to issue #1215