Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful_timeout watcher config option should be float #1115

Merged
merged 1 commit into from
Mar 1, 2020

Conversation

biozz
Copy link
Contributor

@biozz biozz commented Feb 29, 2020

Fixes #1088

  • change reading of graceful_timeout in config to float
  • add separate test with graceful_timeout set as float

- change reading of graceful_timeout in config to float
- add separate test with graceful_timeout set as float
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 41d98fa on biozz:graceful-timeout-float into e509ee5 on circus-tent:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 41d98fa on biozz:graceful-timeout-float into e509ee5 on circus-tent:master.

Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 .

@k4nar
Copy link
Contributor

k4nar commented Mar 1, 2020

The build fails due to an unrelated error (PyYAML stopped supporting py34). I'll fix it in another PR.

@k4nar k4nar merged commit 95905cf into circus-tent:master Mar 1, 2020
@biozz
Copy link
Contributor Author

biozz commented Mar 1, 2020

If you don't mind, I would like to help with the fix. As far as I understand, tox.ini will now contain a section for py34 with fixed pyyaml version (this one), like so:

[testenv:py34]
deps =
    {[testenv]deps}
    PyYAML<5.3

For some reason travis doesn't work in my forked repo, so I can't be sure until I make a PR.

Although I hope you have plans to drop older python versions support.

@k4nar
Copy link
Contributor

k4nar commented Mar 2, 2020

Ok, thank you!

I think that adding py34: PyYAML<5.3 to the deps section of [testenv] should work as well. Travis should run once you open a PR.

@biozz biozz added this to the 0.17 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config file options have different types in different files
3 participants