You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to have it there, because there are a lot of cases when you define the same config for different watchers and only watcher id is changing.
I like the idea, although I think that keeping everything in the same file would be a great plus. Maybe we could introduce a new section in the conf, and allow to include it?
If you use include syntax you are implying that it should work the same way in circus and other sections, making it consistent. But I agree you can be lost in your config files at times.
Having a new kind of section with extra configs, on the other hand, would work only for watcher. Because you usually don't have repeating stuff in socket or env. And I am also not sure how can we call that new section kind. Something like common or extra. Calling it include will make it inconsistent in my opinion.
And this looks a bit strange to me:
[watcher:app_1]cmd = echo
extra = logs
[watcher:app_2]cmd = echo
extra = logs
[extra:logs]stdout_stream.class = FileStream
@k4nar, could you please give an example config how you see it done?
This is an attempt to implement circus-tent#1119. For now only configs and tests
are added and some drafts in the config loader. This is still work in
progress.
There is a
include
directive in circus section of the config - https://circus.readthedocs.io/en/latest/for-ops/configuration/#circus-single-sectionBut there is no such thing in watcher section.
It would be nice to have it there, because there are a lot of cases when you define the same config for different watchers and only watcher id is changing.
For example - https://circus.readthedocs.io/en/latest/for-ops/papa/ has at lease these duplicated rows lines:
So if we have include directive for this we can do something like this:
The text was updated successfully, but these errors were encountered: