Move withdraw logic to PoolWithdrawManager contract #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployPool
anddeployPermissionedPool
test support files, which exposed some poorly written tests (some tests incorrectly relied on poolAdmin/Manager being the first record returned fromethers.getSigners()
).Methods from Pool.sol were copied over as-is to the PoolWithdrawManager.sol file. The following were the changes that had to be made:
owner
field, since the Pool was proxying.The gains aren't phenomenal, but will be better when we drop the proxy methods: