VAL-62 Part 1: add first e2e scenario test #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
really impressive excel skills |
venables
reviewed
Nov 1, 2022
test/Loan.test.ts
Outdated
| @@ -1140,6 +1140,8 @@ describe("Loan", () => { | |||
| await loan.connect(borrower).drawdown(); | |||
| expect(await loan.originationFee()).to.equal(416); | |||
|
|
|||
| 833.333333333; | |||
There was a problem hiding this comment.
Looks like a stray statement here
bricestacey
reviewed
Nov 1, 2022
| @@ -16,7 +16,7 @@ describe("FeeVault", () => { | |||
| await feeVault.deployed(); | |||
|
|
|||
| const Asset = await ethers.getContractFactory("MockERC20"); | |||
| const asset = await Asset.deploy("Test Coin", "TC"); | |||
| const asset = await Asset.deploy("Test Coin", "TC", 18); | |||
There was a problem hiding this comment.
isn't USDC and EUROC 6 decimals?
There was a problem hiding this comment.
https://etherscan.io/token/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48
it shouldn't change anything though
There was a problem hiding this comment.
For the existing tests, like this one, I left them as-is (since openzepp defaults to 18, which we were using previously). For the scenario test, I specifically mimicked USDC with 6 decimals since that's what we're testing.
bricestacey
previously approved these changes
Nov 2, 2022
bricestacey
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started adding them under tests/scenarios/business