Add verite credential support #69
Conversation
| string schema; // indicator of the type of verification result | ||
| address subject; // address of the subject of the verification | ||
| uint256 expiration; // expiration of verification (may or may not be expiration of the VC) | ||
| string verifier_verification_id; // Unique ID from the verifier |
There was a problem hiding this comment.
This is a new field -- based on the documentation, it appears Circle added it for their API
| @@ -60,32 +110,144 @@ contract PoolAccessControl is IPoolAccessControl { | |||
| * @inheritdoc IPoolAccessControl | |||
| */ | |||
| function isValidLender(address addr) external view returns (bool) { | |||
| return _allowedLenders[addr]; | |||
| return | |||
| _tosRegistry.hasAccepted(addr) && | |||
There was a problem hiding this comment.
Since ToS acceptance is one-way (can't be revoked, at least currently), do we need to check it again here? I think we check on write for both allowList and Verite? Can't hurt to leave it in, but just double-checking my understanding is correct.
There was a problem hiding this comment.
Oh right! I forgot you intentionally left it out here. I'll update
| @@ -5,6 +5,8 @@ import "./interfaces/IPoolAccessControl.sol"; | |||
| import "./interfaces/IPermissionedServiceConfiguration.sol"; | |||
| import "./interfaces/IToSAcceptanceRegistry.sol"; | |||
| import "../interfaces/IPool.sol"; | |||
| import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | |||
| import "@openzeppelin/contracts/utils/cryptography/draft-EIP712.sol"; | |||
There was a problem hiding this comment.
I notice that it got bumped out of draft, at least in GH: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/EIP712.sol. I think we're on the latest though, which doesn't seem to have it yet.
There was a problem hiding this comment.
Yeah i was looking too and it appears its only in the 4.8.0-rc, not yet mainline
We check whenever adding an address, so we do not need to use the cycles checking here every time
No description provided.