Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the rounding per 4626 to round UP in certain cases. Per 4626,
convertToAssets
,convertToShares
should both round DOWNpreviewDeposit
, anddeposit
should round DOWN (i.e. calculating how many Y shares to mint for X assets)previewMint
, andmint
should round UP (i.e. calculating how many Y assets to transfer from lender to mint X shares)previewWithdraw
, andwithdraw
rounds UP (i.e. calculating how many shares required to withdraw assets)previewRedeem
, andredeem
rounds DOWN (i.e. calculating how many assets to transfer TO lender for X shares)Please sanity check that's correct: https://eips.ethereum.org/EIPS/eip-4626#security-considerations
Also simplified some of the PoolLib methods since they were duplicative at this point (consolidated to a single
PoolLib.calculateConversion
method).