Add totalAvailableAssets methods which account for withdrawable/redeemable funds
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
approved these changes
Oct 24, 2022
| @@ -35,6 +35,7 @@ interface IERC4626 is IERC20 { | |||
|
|
|||
| /** | |||
| * @dev Calculate the total amount of underlying assets held by the vault. | |||
| * NOTE: This method includes assets that are marked for withdrawal. | |||
There was a problem hiding this comment.
What do you think is more in the spirit of 4626? To include or exclude earmarked assets? I honestly don't know
There was a problem hiding this comment.
I was thinking this would more closely map to totalSupply (which would include not-yet-redeemed tokens), which is my guess for what 4626 was going for.
| // 48 shares should be available due to 25% withdraw gate. | ||
| expect(await pool.totalRedeemableBalance()).to.equal(41); | ||
| // 170 assets, 25% withdraw gate = 42 assets. | ||
| expect(await pool.totalWithdrawableAssets()).to.equal(41); // 42? |
There was a problem hiding this comment.
Is the 41 unexpected? Just looking at the 42?
There was a problem hiding this comment.
Ah yeah. I believe it should be 41, but was previously 42 due to some of the rounding + fx rate calculation changes. Will update in follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.