Add support for defaults #44
Conversation
| function defaultLoan(address loan) | ||
| external | ||
| onlyManager | ||
| atState(IPoolLifeCycleState.Active) |
There was a problem hiding this comment.
This is definitely correct, but I was torn whether we want it to be enforced, or leave it to the PM's discretion if something gets into a weird state (only way that it could would be a bug, but still).
| @@ -219,13 +224,31 @@ contract Pool is IPool, ERC20 { | |||
| function fundLoan(address addr) external onlyManager { | |||
| ILoan loan = ILoan(addr); | |||
| loan.fund(); | |||
| _accountings.activeLoanPrincipals += loan.principal(); | |||
There was a problem hiding this comment.
This might be overwritten by the loan funding work, but the accounting in the default overflows without it, so I added it in
| /** | ||
| * @dev Mapping of created loans | ||
| */ | ||
| mapping(address => bool) private _isLoan; |
There was a problem hiding this comment.
calling this one out -- I can see an argument for this to instead live on the ServiceConfiguration, perhaps in a larger mapping keyed off of the loanFactory address.
This would map loanFactoryAddress => createdLoanAddress => bool, or something similar.
This might be slightly more testable, but perhaps overloads the Config contract. Curious if anyone has thoughts!
| /** | ||
| * @dev Holds a reference to valid LoanFactories | ||
| */ | ||
| mapping(address => bool) public isLoanFactory; |
There was a problem hiding this comment.
See other comment re: LoanFactory mapping
Changes:
defaultLoanon the Pool, callable by the PM only while the pool isActiveactiveLoanPrincipalsaccording to the defaulted loan principal