Allow PM withdrawals of first loss once a pool is closed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Sep 28, 2022
| @@ -18,7 +18,7 @@ contract FirstLossVault { | |||
| /** | |||
| * @dev Modifier restricting access to pool | |||
| */ | |||
| modifier isPool() { | |||
| modifier onlyPool() { | |||
added 4 commits
September 29, 2022 10:00
…date depositing FL method to specify a supplier.
venables
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the
supplyFirstLossmethod name to align with thedeposit/withdrawverbiage used elsewhere. Additionally, it updates the signature to allow specifying asupplieraddress on deposit, and areceiveraddress on withdraw, so that the PM account doesn't necessarily have to custody the FL.Small house-keeping items:
librarydirectory tolibraries, for consistency withinterfaces(both plural)libraries(saw that Matt had added apermissionsubdirectory, and makes sense to organize them similarly to thecontractsdir)