Disable pool token transfers #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venables
previously approved these changes
Sep 28, 2022
bricestacey
reviewed
Sep 28, 2022
| to == address(0) || from == address(0), | ||
| "Pool: transfers disabled" | ||
| ); | ||
| } |
There was a problem hiding this comment.
I believe this should call into super, though I'm not sure it matters for this implementation? https://docs.openzeppelin.com/contracts/4.x/extending-contracts#using-hooks
Always call the parent’s hook in your override using super. This will make sure all hooks in the inheritance tree are called: contracts like ERC20Pausable rely on this behavior.
There was a problem hiding this comment.
Chatted IRL, going to update this to call super in case we inherit a different ERC20 implementation in the future that has hook functionality.
venables
previously approved these changes
Sep 28, 2022
… denied through OpenZeppelin library.
venables
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.