Add flow for depositing into the pool #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Sep 27, 2022
contracts/Pool.sol
Outdated
| this.previewDeposit(assets), | ||
| this.maxDeposit(receiver) | ||
| ); | ||
| _mint(receiver, shares); |
There was a problem hiding this comment.
Since _mint is internal, the library can't call it. Not sure a good pattern for this; ideally we could move everything to the library for testability; not crazy about having the boundary here.
venables
reviewed
Sep 27, 2022
| atState(PoolLifeCycleState.Active) | ||
| returns (uint256 shares) | ||
| { | ||
| // TODO: check lender ACLs for both msg.sender and receiver |
There was a problem hiding this comment.
This TODO can be part of the PermissionedPool logic (once it lands)
There was a problem hiding this comment.
Yep, will rebase mine + update it once that lands!
venables
previously approved these changes
Sep 28, 2022
added 8 commits
September 28, 2022 09:36
venables
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left one question below in-line