Add ERC-4246 and IPool interfaces #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Sep 19, 2022
| /** | ||
| * @titleExpresses the various states a pool can be in throughout its lifecycle. | ||
| */ | ||
| enum PoolLifeCycleState { |
There was a problem hiding this comment.
Not sure the convention we want to follow for these smaller supporting types: 1) separate files, 2) within the interface definition as an inner type, or 3) same file as interface, but outside interface definition. No strong feelings either way!
bricestacey
previously approved these changes
Sep 20, 2022
contracts/interfaces/IPool.sol
Outdated
| /** | ||
| * @dev Emitted when a funded loan is marked as in default. | ||
| */ | ||
| event LoanDefaultDefaulted(address indexed loan); |
There was a problem hiding this comment.
Also, there is a late fee which may come before this and may require another event. I think we can address it later though.
There was a problem hiding this comment.
Indeed, good catch!
venables
previously approved these changes
Sep 20, 2022
venables
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an interface for the ERC 4246 standard, as well as an IPool interface with some initial functions. Left some questions in-line.