-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalajs / sconfig Support #191
base: master
Are you sure you want to change the base?
Conversation
arashi01
commented
Jan 24, 2021
- Adds support for sconfig library as alternative to Typesafe Config
- Adds support for Scala.js (using sconfig library)
@jonas, @travisbrown Any chance you can have a quick look and let me know your thoughts? Would be great to have Scala.js support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The idea sounds reasonable to me, although it's @jonas's decision to make. I also haven't looked at the generation code in detail.
Okay great! The converters in Predef can be used when called explicitly. Will wait on additional feedback before making the change. Should be a quick fix. |
@jonas any chance you can have a look at this? |
Hi @travisbrown @jonas , is this going to be merged into master and if not what is the recommended way to use HOCON files in scalajs? I currently use circe for all scalajs json serde and am migrating to hocon for smaller footprint. What are my options until this is supported here? |
I'm only doing maintenance on this project (merging Scala Steward PRs, publishing releases, etc.), and I've had enough trouble with Scala.js support in other projects that I don't personally want to sign up to maintain it here (or to volunteer @jonas to do that). I do appreciate that you've put in this effort, and if you'd be willing to volunteer to join the project as a maintainer (or know someone who would), and if @jonas agrees, that might be a way forward. |
@travisbrown I am happy to clean this up if needed in any way to get it merged. Also happy to volunteer as a maintainer if needed in order to support Scala JS and Scala Native. |
@jonas Any chance of your input on this? As mentioned before, if you're willing, I'm happy to make any changes necessary to get this merged. Also happy to volunteer as an additional maintainer if necessary to handle standard housekeeping/maintenance issues. cc @travisbrown |
I'll plan to merge and publish this if nobody speaks up by this Tuesday (the 9th). |
- 0.7.0 Previously not included in mimaPreviousArtifacts - Derive mimaPreviousArtifacts for circe-sconfig from circe-config
1544046
to
d76caf0
Compare
Okay great. Just rebased on top of current mainline. |