Blurhash support #701
Merged
Blurhash support #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Element web does a kind of pulsing animation to signalize that it's not the actual image/thumbnail yet (matrix-org/matrix-spec-proposals#2448 (comment)). Should we do something similar? |
|
I think it is good as it is now. And also match the message loading placeholder. |
NovaAndrom3da
pushed a commit
to NovaAndrom3da/neocinny
that referenced
this pull request
Nov 23, 2023
* Generate blurhash client side * Make blurhash generation faster * Simple blurhash display support * Make image display simpler * Support non square images * Don't attach video blurhash to thumbnail * Add video display support * Ignore alt tag missing warning Co-authored-by: Ajay Bura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds blurhash support as for MSC2448.
2022-08-04.09-25-11.mp4
(With "Good 3G" network throttle option)
Type of change
Checklist:
Preview: https://62ede4ef4739797ad4345d50--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️