Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state of the icons in Toolbar being too hard to see #2091

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

verbey
Copy link

@verbey verbey commented Dec 14, 2024

Description

This makes Cinny use filled variants of icons present in the Toolbar. I believe this is important because as of right now they are only highlighted slightly by the background, which does not differ much (see this color comparison or this one, which is better but still not as good as filled icons) from the background of Toolbar itself and thus makes this an accessibility issue for users with low sight like me.

Obviously, this doesn't change anything without the relevant PR for the folds repo:
cinnyapp/folds#60

To see how it looks like yourself you will have to build Cinny with a local version of the patched folds package. See how this should look like in Cinny with the filled icons:
https://files.catbox.moe/jf3xep.mp4

Fixes icons in Toolbar not having enough visual hints to highlight their state.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Note: I have already made a PR with such a description and name but accidentally did so with the wrong code. Long story short, I've been experimenting on how to improve this and during this time Cinny got updated. I pulled the changes, which made git suggest doing some git merge with the changes. I am not sure how, but it completely reverted the actual patch that I am pushing here and brought back one of the experimental solutions. I am super sorry for this, that was a giant blunder on my side.

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Changing styles of icons is against our ui design system. Using IconButton variant can be used to improve emphasis as per my previous review #2090 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants