Fix state of the icons in Toolbar being too hard to see #2091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes Cinny use filled variants of icons present in the Toolbar. I believe this is important because as of right now they are only highlighted slightly by the background, which does not differ much (see this color comparison or this one, which is better but still not as good as filled icons) from the background of Toolbar itself and thus makes this an accessibility issue for users with low sight like me.
Obviously, this doesn't change anything without the relevant PR for the folds repo:
cinnyapp/folds#60
To see how it looks like yourself you will have to build Cinny with a local version of the patched folds package. See how this should look like in Cinny with the filled icons:
https://files.catbox.moe/jf3xep.mp4
Fixes icons in Toolbar not having enough visual hints to highlight their state.
Type of change
Checklist:
Note: I have already made a PR with such a description and name but accidentally did so with the wrong code. Long story short, I've been experimenting on how to improve this and during this time Cinny got updated. I pulled the changes, which made git suggest doing some git merge with the changes. I am not sure how, but it completely reverted the actual patch that I am pushing here and brought back one of the experimental solutions. I am super sorry for this, that was a giant blunder on my side.