Fix notifications not being sent on decryption correction #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Oct 4, 2024
TrojanerHD
force-pushed
the
fix-notification-for-first-message
branch
from
25e4699 to
80b8526
Compare
ajbura
reviewed
Nov 27, 2024
Comment on lines
+208
to
+212
| const handleUnreadEvent: RoomEventHandlerMap[RoomEvent.UnreadNotifications] = () => { | ||
| handleTimelineEvent(mEvent, room, toStartOfTimeline, removed, data); | ||
| room.removeListener(RoomEvent.UnreadNotifications, handleUnreadEvent); | ||
| }; | ||
| room.on(RoomEvent.UnreadNotifications, handleUnreadEvent); |
There was a problem hiding this comment.
since you are removing the listener inside event handler, it feels like to me that following change may lead to memory leaks where the event handler is set but never gets removed because you never hear from it?
There was a problem hiding this comment.
Yes, that is something I did not consider. I don't really know how to tackle this - my only idea would be to remove the listener after some time. Or I could change it such that for each room there will be at most one listener which would still add memory overhead but constant in the number of rooms the user joined 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1892
My analysis in the issue actually seems to be wrong. The root cause for this issue is not the cache but the fact that the matrix-js-sdk sends a timeline event before calling the fixNotificationCountOnDecryption function (see https://github.com/matrix-org/matrix-js-sdk/blob/da044820d7d3255e41e403bfbd035bf7b90ddd6a/src/client.ts#L10322). This leads to the edge case that cinny returns in the sendTimelineEvent function as the counter is 0 before it is corrected to 1.
Type of change
Checklist: