Add setting to enable 24-hour time format #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://1739--pr-cinny.netlify.app |
ajbura
reviewed
May 15, 2024
ajbura
requested changes
May 16, 2024
|
|
||
| export type TimeProps = { | ||
| compact?: boolean; | ||
| ts: number; | ||
| }; | ||
|
|
||
| export const Time = as<'span', TimeProps>(({ compact, ts, ...props }, ref) => { | ||
| const [hour24Clock] = useSetting(settingsAtom, 'hour24Clock'); |
There was a problem hiding this comment.
Subscribing to settingsAtom inside Time component can downgrade the perf of our timeline as every Time component in every message will be listening to it where more perf oriented approach can be to receive hour24Clock as component param and we can subscribe to settingsAtom once for all.
|
@agmm are you still willing to update this PR? |
|
I totally forgot about this PR, but yes, I am willing to update it. I will take a look as soon as I have the time. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for the 24-hour time format has been a frequently requested feature in the Cinny Matrix room and has been mentioned in multiple issues: #60, #1333, #1549, #1648. This PR adds a toggle in the settings page that allows the user to switch between 12-hour and 24-hour time formats.
Type of change
Checklist: