Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation in the CRD for maxData and returnCopy flags and update doc #965

Merged
merged 1 commit into from
May 4, 2023
Merged

Add documentation in the CRD for maxData and returnCopy flags and update doc #965

merged 1 commit into from
May 4, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented May 2, 2023

Fixes #958.

@mtardy mtardy added the area/documentation Improvements or additions to documentation label May 2, 2023
@mtardy mtardy requested a review from a team as a code owner May 2, 2023 17:59
@mtardy mtardy requested a review from olsajiri May 2, 2023 17:59
@netlify
Copy link

netlify bot commented May 2, 2023 •
edited
Loading

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 1b06dc2
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64521975d364850008aab161
😎 Deploy Preview https://deploy-preview-965--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kkourt
kkourt approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits from my side, thanks!

docs/content/en/docs/reference/tracing-policy.md Outdated Show resolved Hide resolved
docs/content/en/docs/reference/tracing-policy.md Outdated Show resolved Hide resolved
@mtardy
CRD: add documentation for maxData and returnCopy flag
593f414 
Also enrich the TracingPolicy reference documentation about these flags.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy force-pushed the pr/mtardy/crd-docs branch from 1b06dc2 to 593f414 Compare May 3, 2023 08:22
@kkourt kkourt merged commit 17e141c into main May 4, 2023
@kkourt kkourt deleted the pr/mtardy/crd-docs branch May 4, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@olsajiri olsajiri Awaiting requested review from olsajiri olsajiri is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add description in CRD definition to explain returnCopy and maxData fields
2 participants
@mtardy @kkourt