testing fixes. #94
Merged
testing fixes. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
approved these changes
May 27, 2022
Signed-off-by: Kornilios Kourtis <[email protected]>
We are seeing tests fail with the following errors:
kprobe_sigkill_test.go:33: error reading stderr> : read |0: file already closed
kprobe_sigkill_test.go:33: error reading stdout> : read |0: file already closed
One potential reason for this is that we wait on the commands before the
reads from the stderr/stdout pipes have completed, which is incorrect:
https://pkg.go.dev/os/exec#Cmd.StderrPipe.
this patch fixes this.
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/test-pipes-fixes
branch
from
fd17966 to
8fbf38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits.
Fixes: #82