Skip to content

Various Dockerfile cleanups #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2023
Merged

Various Dockerfile cleanups #843

merged 3 commits into from
Apr 5, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Mar 28, 2023

No description provided.

@mtardy mtardy added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 28, 2023
@mtardy mtardy requested a review from a team as a code owner March 28, 2023 10:27
@mtardy mtardy requested a review from olsajiri March 28, 2023 10:27
@mtardy mtardy force-pushed the pr/mtardy/dockerfile-cleanup branch from 07747f8 to e3ebef6 Compare March 28, 2023 10:44
@mtardy mtardy requested a review from willfindlay as a code owner March 28, 2023 10:44
@cilium cilium deleted a comment from netlify bot Mar 28, 2023
@mtardy mtardy force-pushed the pr/mtardy/dockerfile-cleanup branch from e3ebef6 to 159a862 Compare March 28, 2023 12:00
@willfindlay
Copy link
Contributor

Build job will need updating to account for the rename.

@mtardy
Copy link
Member Author

mtardy commented Mar 29, 2023

Build job will need updating to account for the rename.

It is updated, but the the build job is a pull_request_target.

@mtardy
Copy link
Member Author

mtardy commented Mar 29, 2023

See https://github.com/cilium/tetragon/pull/843/files#diff-bc7d1a70d1cf51591f508724daa5a8e98f987c7a594acd8e40d3fe4b8da9e319R33

@mtardy
Copy link
Member Author

mtardy commented Mar 29, 2023

Do you want to proceed like usual? Changing to pull_request to test the impossible-to-test pull_request_target?

@willfindlay
Copy link
Contributor

Do you want to proceed like usual? Changing to pull_request to test the impossible-to-test pull_request_target?

Yeah let's do a rebase and then let's test with the pull_request target.

mtardy added 3 commits April 5, 2023 15:19
@mtardy
Remove Dockerfile.clang thanks to PR #743
8295cc0 
The base image used is arm64 compatible so can be built locally and the
workflow use emulation to provide an arm64 from the quay repo, see here:
https://quay.io/repository/cilium/clang.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy
Rename operator Dockerfile to follow convention
abba7da 
Signed-off-by: Mahe Tardy <[email protected]>
@mtardy
Dockerfile: remove useless RUN cmd debug artifact
44aab01 
Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy force-pushed the pr/mtardy/dockerfile-cleanup branch from 159a862 to 3dde191 Compare April 5, 2023 13:21
@mtardy
Copy link
Member Author

mtardy commented Apr 5, 2023 •
edited
Loading

It works as intended https://github.com/cilium/tetragon/actions/runs/4618951104/jobs/8167042859?pr=843. Pushing the branch without the commit with pull_request target.

@mtardy mtardy force-pushed the pr/mtardy/dockerfile-cleanup branch from 3dde191 to 44aab01 Compare April 5, 2023 13:27
@mtardy mtardy removed the request for review from olsajiri April 5, 2023 13:28
@mtardy
Copy link
Member Author

mtardy commented Apr 5, 2023

I think this is ready now @willfindlay, wdyt?

@mtardy
Copy link
Member Author

mtardy commented Apr 5, 2023

Not all the checks succeed because of the rename of operator.Dockerfile to Dockerfile.operator but this is expected because the workflow use pull_request_target event. Tests were made adding the pull_request target. Merging this now!

@mtardy mtardy merged commit b219849 into main Apr 5, 2023
@mtardy mtardy deleted the pr/mtardy/dockerfile-cleanup branch April 5, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willfindlay willfindlay willfindlay approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtardy @willfindlay