makefile: make LOCAL_CLANG=0 the default #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
approved these changes
May 25, 2022
tpapagian
approved these changes
May 25, 2022
Needing to manually specify LOCAL_CLANG=0 was complicating the build process for the UX point of view and resulting in user error when building BPF programs. Let's make LOCAL_CLANG=0 the default. This can always be overridden if the user is absolutely sure. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/makefile
branch
from
156baa5 to
311331f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needing to manually specify LOCAL_CLANG=0 was complicating the build process for the UX
point of view and resulting in user error when building BPF programs. Let's make
LOCAL_CLANG=0 the default. This can always be overridden if the user is absolutely sure.
Signed-off-by: William Findlay [email protected]