fix char buff matchargs #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
force-pushed
the
pr/kkourt/char_buf_matchargs
branch
5 times, most recently
from
8db372e to
3ed70aa
Compare
Strings and buffers are encoded differently, but they do use the same function for filtering. As a result, filtering buffers did not work. This patch fixes this by adding a new argument filter_char_buf and passing the appropriate value for strings and buffers. The patch also removes an unneeded variable (v). Note that we also change the bound of length to be <=255 which was the same bound for v (since it was a char casted into an int). Signed-off-by: dechengyuan <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
This patch adds tests for the issue that was fixed in the previous commit. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/char_buf_matchargs
branch
from
3ed70aa to
390d309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the patch from @Y-dc (see #576) and added a test for it.