Skip to content

Update Makefile test target dependencies and run test as root #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

Update Makefile test target dependencies and run test as root #649

merged 2 commits into from
Jan 24, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jan 19, 2023

  • Make explicit the implicit dependencies there were between tetragon-bpf and tester-progs for the target test. Also, run the tests as root with sudo using the SUDO variable.
  • Simplify the associated GitHub action

@mtardy mtardy requested review from willfindlay and a team as code owners January 19, 2023 14:43
@mtardy mtardy added kind/enhancement This improves or streamlines existing functionality area/ci Related to CI area/testing Related to testing labels Jan 19, 2023
@kkourt kkourt merged commit 507a293 into main Jan 24, 2023
@kkourt kkourt deleted the pr/mtardy/makefile-test branch January 24, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@willfindlay willfindlay willfindlay approved these changes

Assignees
No one assigned
Labels
area/ci Related to CI area/testing Related to testing kind/enhancement This improves or streamlines existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtardy @kkourt @willfindlay