ci: move checkpatch to its own job and add some exceptions #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpatch lints are often overly aggressive and we like to ignore them when necessary. However, doing so might mean we miss other important lints from that static-checks job. Let's move checkpatch.pl to its own job to fix this. Another reason for this change is that checkpatch.pl is not a static check per se. Rather, it checks individual commits for correctness. Signed-off-by: William Findlay <[email protected]>
Let's ignore PREFER_DEFINED_ATTRIBUTE_MACRO and C99_COMMENTS in checkpatch.pl. We use __attribute__((always_inline)) all over our codebase and C99_COMMENTS issues false positives for spdx license identifiers. Both of these should be considered false positives, so just ignore them. Signed-off-by: William Findlay <[email protected]>
michi-covalent
approved these changes
May 23, 2022
michi-covalent
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed by commit.