jsonchecker: retry on EOF/UnexpectedEOF in unmarshaller #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a corner case in CI a few times where it seems that the exporter is in the middle of writing an event when the jsonchecker decides to open the file and check it. In this case, the unmarshaller will bubble up either an EOF or UnexpectedEOF error which will fail the test. To handle this, let's just treat these errors the same way we treat regular JSON EOF: by retrying after a few seconds. Signed-off-by: William Findlay <[email protected]>
kkourt
approved these changes
Dec 10, 2022
tixxdz
approved these changes
Dec 10, 2022
tpapagian
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a corner case in CI a few times where it seems that the exporter is in the middle of writing an event when the jsonchecker decides to open the file and check it. In this case, the unmarshaller will bubble up either an EOF or UnexpectedEOF error which will fail the test. To handle this, let's just treat these errors the same way we treat regular JSON EOF: by retrying after a few seconds.
Signed-off-by: William Findlay [email protected]