Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Add event config map #53

Merged
merged 11 commits into from
Jun 3, 2022
Merged

tetragon: Add event config map #53

merged 11 commits into from
Jun 3, 2022

Conversation

olsajiri
Copy link
Contributor

Getting rid of extra configuration inside BTF and moving it to map.

The new internal config_map map is loaded for both tracepoints
and kprobes and loaded with config data at zero index.

Signed-off-by: Jiri Olsa [email protected]

@olsajiri olsajiri force-pushed the kill_btf branch 10 times, most recently from c481f4b to bbbaced Compare May 28, 2022 13:53
@olsajiri olsajiri marked this pull request as ready for review May 28, 2022 19:28
@olsajiri olsajiri requested a review from a team as a code owner May 28, 2022 19:28
@olsajiri
Copy link
Contributor Author

I'm now suddenly getting this panic:
panic: test timed out after 10m0s

need to figure this out, moving to draft again

@olsajiri olsajiri marked this pull request as draft May 29, 2022 07:54
@olsajiri olsajiri marked this pull request as ready for review May 29, 2022 22:18
@olsajiri
Copy link
Contributor Author

I'm now suddenly getting this panic: panic: test timed out after 10m0s

need to figure this out, moving to draft again

must be my setup, increased the timeout and all's passed

@kkourt
Copy link
Contributor

kkourt commented May 30, 2022

I'm now suddenly getting this panic: panic: test timed out after 10m0s
need to figure this out, moving to draft again

must be my setup, increased the timeout and all's passed

Did a make test on my machine (with go clean -testcache before), and this is what I got:

main: 51.46s user 133.45s system 60% cpu 5:06.75 total
#53: 49.39s user 157.57s system 63% cpu 5:28.15 total

so there does not seem to be a big difference between the two.

@willfindlay
Copy link
Contributor

I've seen local test timeouts like this when I've done a lot of make test and subsequently killing with ctrl-c. Basically, the sensors aren't being unloaded properly which ends up putting the system in a not-so-sane state. Any change that might be what's happening here?

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter caught this typo.

bpf/process/bpf_generic_retkprobe.c Outdated Show resolved Hide resolved
olsajiri added 11 commits May 30, 2022 19:29
I had several failures due to context timeout with this test
when running on loaded machine.

The test is loading 4 kprobes so the load/verification can
cross 20 second limit, increasing it to 60s for this test.

Signed-off-by: Jiri Olsa <[email protected]>
We should display ArgM type in here.

Signed-off-by: Jiri Olsa <[email protected]>
Add map with config data so it can replace BTF config data
completely. Starting with func_id, other fields will come
in following changes.

The new internal config_map map is loaded for both tracepoints
and kprobes and loaded with config data at zero index.

Signed-off-by: Jiri Olsa <[email protected]>
Adding arg types to the config map and using them in bpf
code instead of the argX BTF fields.

Signed-off-by: Jiri Olsa <[email protected]>
Adding arg meta values to the config map and using them
in bpf code instead of the argXm BTF fields.

Signed-off-by: Jiri Olsa <[email protected]>
Adding tp ctx offset values to the config map and using them
in bpf code instead of the t_argX_ctx_off BTF fields.

Signed-off-by: Jiri Olsa <[email protected]>
Adding sigkill value to the config map and using it
in bpf code instead of the sigkill BTF field.

Signed-off-by: Jiri Olsa <[email protected]>
Adding syscall value to the config map and using it
in bpf code instead of the syscall BTF field.

Signed-off-by: Jiri Olsa <[email protected]>
Adding argreturncopy type to the config map and using it
in bpf code instead of the argreturncopy BTF field.

Signed-off-by: Jiri Olsa <[email protected]>
Adding argreturn type to the config map and using it
in bpf code instead of the argreturn BTF field.

Signed-off-by: Jiri Olsa <[email protected]>
Removing BTF enums and code which is no longer needed,
because we have all the data in the config map.

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri
Copy link
Contributor Author

I've seen local test timeouts like this when I've done a lot of make test and subsequently killing with ctrl-c. Basically, the sensors aren't being unloaded properly which ends up putting the system in a not-so-sane state. Any change that might be what's happening here?

right, that could easily happened

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olsajiri olsajiri changed the title hubble-fgs: Add event config map tetragon: Add event config map Jun 1, 2022
@jrfastab jrfastab merged commit 7967642 into cilium:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants