metrics: split metrics into separate packages #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
approved these changes
May 21, 2022
willfindlay
force-pushed
the
pr/willfindlay/refactor-metrics
branch
2 times, most recently
from
af66f14 to
a9eb4b3
Compare
kkourt
approved these changes
May 23, 2022
This commit moves error totals into their own package and implements convenience helpers for incrementing them. Signed-off-by: William Findlay <[email protected]>
This commit moves op code totals into their own package and implements convenience helpers for incrementing them. Signed-off-by: William Findlay <[email protected]>
This commit moves event metrics into their own package. Signed-off-by: William Findlay <[email protected]>
This commit moves eventcache metrics into their own package and implements convenience helpers for incrementing them. Signed-off-by: William Findlay <[email protected]>
This commit moves map size metrics into their own package and implements convenience helpers for incrementing and setting them. Signed-off-by: William Findlay <[email protected]>
This commit moves ringbuf metrics into their own package and implements convenience helpers for incrementing and setting them. Signed-off-by: William Findlay <[email protected]>
This commit moves process exec metrics into their own package and implements convenience helpers for incrementing and setting them. Signed-off-by: William Findlay <[email protected]>
This commit moves kprobe metrics into their own package and implements convenience helpers for incrementing and setting them. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/refactor-metrics
branch
from
a9eb4b3 to
62f5b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the metrics into separate packages to make them easier to work with and reason about. It also adds some convenience helpers to avoid developer error when setting metric labels.