Skip to content

fix: honor -stderrthreshold when -logtostderr is set #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierluigilenoci wants to merge 1 commit into from
Closed

fix: honor -stderrthreshold when -logtostderr is set #4903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/logger/klog_bridge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ func initializeKLog(logger *slog.Logger) error {
// update them from this file.
klog.InitFlags(klogFlags)

// Opt into the new klog behavior so that -stderrthreshold is honored even
// when -logtostderr=true (the default).
// Ref: kubernetes/klog#212, kubernetes/klog#432
klogFlags.Set("legacy_stderr_threshold_behavior", "false") //nolint:errcheck
klogFlags.Set("stderrthreshold", "INFO") //nolint:errcheck

// Make sure klog does not log to stderr as we want it to control the output
// of klog so we want klog to log the errors to each writer of each level.
klogFlags.Set("logtostderr", "false")
Expand Down
Loading