Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENCE #47

Closed
wants to merge 4 commits into from
Closed

Add LICENCE #47

wants to merge 4 commits into from

Conversation

dgkncelik
Copy link
Contributor

Signed-off-by: Doğukan ÇELİK [email protected]

Signed-off-by: Doğukan ÇELİK <[email protected]>
@dgkncelik
Copy link
Contributor Author

dgkncelik commented May 19, 2022

Related issue #45

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just one requested change from me please: s/LICENCE/LICENSE.

Signed-off-by: Doğukan ÇELİK <[email protected]>
@willfindlay
Copy link
Contributor

LGTM, thanks!

@willfindlay
Copy link
Contributor

Actually @dgkncelik one more thing, do you mind squashing those commits? Thanks :)

dgkncelik added 2 commits May 19, 2022 22:13
Signed-off-by: Doğukan ÇELİK <[email protected]>

Fix file name typo

Signed-off-by: Doğukan ÇELİK <[email protected]>
@dgkncelik
Copy link
Contributor Author

sorry for the inconvience :(
just opened new pull request with correct naming
#48

@dgkncelik dgkncelik closed this May 19, 2022
@dgkncelik dgkncelik deleted the add-licence branch May 19, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants