use CONTAINER_ENGINE variable instead of literal 'docker' #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitris
changed the title
joestringer
approved these changes
May 18, 2022
|
Would you mind squashing the two commits & force push to update the PR? |
Signed-off-by: Dmitry Savintsev <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces the use of the literal
dockerin theMakefilewithCONTAINER_ENGINEwhich hasdockeras the default value (but can be customized by the user - for example, to runmake tools-install CONTAINER_ENGINE='sudo podman'). For the "normal" invocations, nothing should change -dockerstill will be invoked.Signed-off-by: Dmitry Savintsev [email protected]