testutils: fix export file when test name contains path separator #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
approved these changes
Sep 15, 2022
|
@kkourt I just realized I have to fix up some of the other funcs that expect a test name as well. Marking as draft till then. |
Subtests in Go have a path separator ("/") in their name. This breaks our export file
creation since it is considered an error by os.CreateTemp(). Replace the path separator
with a "-" here to correct this.
Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/fix-export-file-path-separator
branch
from
e1f6058 to
780968b
Compare
|
There we go, should be fixed. |
willfindlay
deleted the
pr/willfindlay/fix-export-file-path-separator
branch
Why was needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtests in Go have a path separator ("/") in their name. This breaks our export file creation since it is considered an error by os.CreateTemp(). Replace the path separator with a "-" here to correct this.
Signed-off-by: William Findlay [email protected]