helm: make gRPC and metrics address/port configurable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll review this today i have a couple of suggestions 🙏 |
willfindlay
force-pushed
the
pr/willfindlay/configurable-addresses
branch
from
7c9b584 to
e972e2b
Compare
|
@michi-covalent I fixed up the changes you suggested, thanks. |
This patch makes the gRPC address and port configurable in helm and adds a similar option to configure the metrics address. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/configurable-addresses
branch
from
e972e2b to
6e00380
Compare
michi-covalent
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the gRPC address and port configurable in helm and adds a similar option
to configure the metrics address. Fixes #40.
Signed-off-by: William Findlay [email protected]