logging: slight improvement to observer logging #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously silently ignoring error messages in an our event handlers. It's probably better if we log them here instead. Ideally we shouldn't have any errors in our event handlers so I think a level of Warn is fine for now. If it gets to spammy in practice we can drop it to Debug at some point. Signed-off-by: William Findlay <[email protected]>
Switch unknown opcode message to use structured logging and log the event type as a string (if we know it) in addition to the opcode. Finally, switch the log level to warning rather than info, which is more semantically correct here in my opinion. Signed-off-by: William Findlay <[email protected]>
michi-covalent
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log errors from event handlers and use structured logging for opcode errors.