sensor cleanups #381
Merged
sensor cleanups #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
force-pushed
the
pr/kkourt/sensor-cleanups
branch
2 times, most recently
from
ede5786 to
8e67502
Compare
olsajiri
reviewed
Sep 4, 2022
kkourt
force-pushed
the
pr/kkourt/sensor-cleanups
branch
from
8e67502 to
14a47e7
Compare
This is hidden flag added for development/testing, but it is not used anymore. Remove it. Signed-off-by: Kornilios Kourtis <[email protected]>
This was a hidden flag added for development and testing, but it is not used anymore. Remove it and along all the code that was supporting it. Signed-off-by: Kornilios Kourtis <[email protected]>
First, remove pkg/sensors/config. Instead, use GetMergedSensorFromParserPolicy so that we can have a proper name in the sensor (the one from the tracing policy). Based on above change, clean up sensor initialization in tests an in agent main. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/sensor-cleanups
branch
from
14a47e7 to
940ed55
Compare
kevsecurity
reviewed
Sep 12, 2022
willfindlay
approved these changes
Sep 12, 2022
We have been using the cilium/ebpf reader for quite some time now. Let's remove the dual implementation and only keep the new version. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
No need to pass the base sensor as argument. Just get it once from the appropriate function. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/sensor-cleanups
branch
from
940ed55 to
d729849
Compare
tixxdz
approved these changes
Sep 12, 2022
kevsecurity
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commits