kprobe/process: silence verbose warnings + add metrics #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event merge warnings were overly verbose and flooding the logs with useless
information. Silence these warnings by putting them behind a debug flag and add a metric
to help track such errors. This patch is loosely based on a previous version by Jiri but
with some additional information in the metrics.
Tested with crds/examples/sys_write_follow_fd_prefix.yaml and it produces metrics like the following:
isovalent_generic_kprobe_merge_errors{curr_fn="__x64_sys_read",curr_type="enter",prev_fn="__x64_sys_read",prev_type="enter"} 6
Signed-off-by: William Findlay <[email protected]>
Co-authored-by: Jiri Olsa <[email protected]>
This commit silences "read error!" messages when exec id read fails, hides them behind a debug flag, and adds a metric to count such errors. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/metrics
branch
from
41647c9 to
970100f
Compare
olsajiri
approved these changes
May 18, 2022
michi-covalent
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some very verbose warnings that were inundating the logs. Let's silence them behind a debug flag and add a metric to help with debugging.
Best reviewed by commit.