tetragon: Allow retry logic for clone events #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Notify callback to Message interface, so we can prevent final NotifyListeners call. It will be used for clone events which are not actually delivered, but we add retry logic for them in following change. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
late_fork_event
branch
from
7c66675 to
18b1363
Compare
The AddCloneEvent fails to add process the the cache if the parent does not exist - there's no record of it. This can happen for example in TestFork test where fork events can be delivered out of order and tetragon sees the child fork event before the parent's one. Adding retry logic for clone events, which will retry the fork event processing and adding the child process entry after the timeout. During the timeout the parent is updated and following retry logic will add the child's entry properly. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
late_fork_event
branch
from
18b1363 to
bd08b4a
Compare
TestFork was failing on 4.19 for me, with this I can no longer reproduce the fail, so I'm hopeful ;-) |
jrfastab
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AddCloneEvent fails to add process the the cache if
the parent does not exist - there's no record of it.
This can happen for example in TestFork test where fork events
can be delievered out of order and tetragon sees the child fork
event before the parent's one.
Adding retry logic for clone events, which will retry the fork
event processing and adding the hild process entry after the
timeout. During the timeout the parent is updated and following
retry logic will add the child's entry properly.
Signed-off-by: Jiri Olsa [email protected]